Fix: Remove udp connection twice(#1297) #1305
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1305 +/- ##
==========================================
- Coverage 44.64% 44.54% -0.10%
==========================================
Files 485 485
Lines 29534 29540 +6
==========================================
- Hits 13184 13158 -26
- Misses 14945 14971 +26
- Partials 1405 1411 +6
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Thank for your explanation. I have understood the root cause of this error, and I agree with the way this issue is addressed.
The connID(Connection identifier ,app/proxyman/inbound/worker.go:type connID struct) use the connection source and destination to identify different connections. When a inactive connection is removed for inactivity, the new connection that is created later may also be removed as the transport connection is terminate. In this way, the new transport connection and tracked active connection get removed unnecessarily.
This pull request is ready to be merged.
Thanks for your contribution.
Fix #1297